Переглянути джерело

Fixed AsyncLock::WaitAsync cancellation bug

There isn't any code in MQTTnet that actually uses a cancellation token in WaitAsync, so this is more of a preventative thing than a bug fix.  The original code just checks if the task was completed, not whether it was cancelled.  If the process is cancelled immediately before the call to WaitAsync, it'll return as normal (https://referencesource.microsoft.com/#mscorlib/system/threading/SemaphoreSlim.cs,612) rather than throw a cancellation exception.  This change will ensure we only return the releaser if the wait actually ran to completion rather than exited early due to cancellation.  I've tested this, and it properly throws a cancellation exception later on.
release/3.x.x
Paul Fake 5 роки тому
committed by GitHub
джерело
коміт
5c40577bec
Не вдалося знайти GPG ключ що відповідає даному підпису Ідентифікатор GPG ключа: 4AEE18F83AFDEB23
1 змінених файлів з 1 додано та 1 видалено
  1. +1
    -1
      Source/MQTTnet/Internal/AsyncLock.cs

+ 1
- 1
Source/MQTTnet/Internal/AsyncLock.cs Переглянути файл

@@ -23,7 +23,7 @@ namespace MQTTnet.Internal
public Task<IDisposable> WaitAsync(CancellationToken cancellationToken)
{
var task = _semaphore.WaitAsync(cancellationToken);
if (task.IsCompleted)
if (task.Status == TaskStatus.RanToCompletion)
{
return _releaser;
}


Завантаження…
Відмінити
Зберегти