Fork, then clone the repo:
git clone git@github.com:your_username/ModbusMaster.git
Create a topic branch from where you want to base your work
git checkout -b fix/master/my_contribution master
. Please avoid working directly on the master
branch.Follow the style guide
Test your change
$ make
Project must build successfully using make
in order for contribution to be considered.
Make commits of logical units
git diff --check
before committingPush to your fork and submit a pull request
Project maintainers assign labels to Issues and Pull Requests (PRs) to categorize, prioritize, and provide status. The following guidelines and conventions are used in this project:
Bug
- existing code does not behave as described in the project documentation; requires clear test case and be reproducible by project maintainerEnhancement
- improvement to an existing feature (Issue or Pull Request)Feature Requst
- new functionality; requires a well-written, clear user story (Issue)Maintenance
- minor administrative change that does not provide enhancement or introduce new featureQuestion
- self-explanatoryLow
- default priority; new issues generally start hereMedium
- issues are escalated, depending on severity of the issueHigh
- issues are escalated, depending on severity of the issueCritical
- these issues are to be resolved ahead of any otherAbandoned
- issue/PR closed due to inactivityBlocked
- issue/PR will not be resolved/merged (some projects label these items as wontfix
; include explanation in issue/PR)In Progress
- issue has been assigned and is actively being addressed; re-label issue On Hold
with explanation if there will be a significant delayMaintainer Review Needed
- last step prior to merge; PR passes continuous integration tests and is able to be cleanly merged - awaiting review for style, code cleanliness, etc.On Hold
- implementation delayed; provide explanation in issue/PRPending Contributor Response
- issue/PR closed after 14 days of inactivity (re-label Abandoned
at closure)